-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacement of file fragment pattern with pupmod-concat #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed spec folder from tree, as no internally written ruby tests are used in this module
Updated nginx::package::suse PuppetDoc header information to accurately reflect the requirement for all packages as defined within the RPM spec for SuSE and OpenSUSE
Markup file for GitHub was not rendering text properly for third code example
Without this change, the end user of the module may run into issues establishing relationships to the composite class (the main nginx class) For example, the user may declare this relationship expecting nginx to be managed after the yum repositories have been configured: node default { class { 'site::yumconfig': } -> class { 'nginx': } } However, all of the resources exist in implementation classes, which do not have a transitive relationship declared to the nginx class. Without this change, Puppet may very well manage Class['nginx::config'] before Class['site::yumconfig'] even though the user clearly indicated this should not be the case.
Watch out for tab characters. =)
…itive_relationships Feedback/master/composite transitive relationships
This commit puts the majority of the code provided by this module into compliance with the published style guide. Also updated Modulefile to have more sane pre-release values.
Style compliance
This change uses the anchor relationship from the puppetlabs-stdlib module to contain all of the module classes within the main "ntp" class. Without this change, end users of the module may have difficulty ordering things correctly since they will have to peek inside the module and figure out it's internal workings to identify all classes that require relationship edges.
This shows the module user how relationships can be easily added to the main nginx class without peeking inside the guts of the module.
…h_anchors Contain all classes within Class[nginx]
implementation of file fragment pattern - SSL option now is (present|absent)
Damm, sorry about this mistake. Upstream of my fork is puppetlabs/puppetlabs-nginx, not @jfryman repo.. will make a branch with cherry-pick commit to pull request. |
grooverdan
pushed a commit
to openquery/puppet-nginx
that referenced
this pull request
Dec 18, 2013
…host This partially avoids pitfall voxpupuli#2 (http://wiki.nginx.org/Pitfalls)
grooverdan
pushed a commit
to openquery/puppet-nginx
that referenced
this pull request
Mar 4, 2014
…host This partially avoids pitfall voxpupuli#2 (http://wiki.nginx.org/Pitfalls)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of file fragment pattern